Restore hit sound effect for TR1 creatures#1155
Open
AlexxxQ wants to merge 1 commit intoTombEngine:developfrom
Open
Restore hit sound effect for TR1 creatures#1155AlexxxQ wants to merge 1 commit intoTombEngine:developfrom
AlexxxQ wants to merge 1 commit intoTombEngine:developfrom
Conversation
Enable Global Hit SFX for TR1 creatures: TR1_WOLF_HURT TR1_BEAR_HURT TR1_RAT_CHIRP TR1_LION_HURT TR1_GIANT_MUTANT_HIT TR1_SKATEBOARDKID_HIT
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to restore/enable “global hit” sound effects for several TR1 creature hit/hurt events so they can be played consistently (including in the TEN pipeline).
Changes:
- Marks the specified TR1 creature hit/hurt sounds as global so they’re available as global SFX (e.g., wolf/bear/rat/lion/giant mutant/Skateboard Kid hit sounds).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Stranger1992
changed the title
Stranger1992
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable Global Hit SFX for TR1 creatures:
TR1_WOLF_HURT
TR1_BEAR_HURT
TR1_RAT_CHIRP
TR1_LION_HURT
TR1_GIANT_MUTANT_HIT
TR1_SKATEBOARDKID_HIT
Depends on: TombEngine/TombEngine#1921