add SARAH with tests#2274
Open
epapoutsellis wants to merge 2 commits intoTomographicImaging:masterfrom
Open
Conversation
gfardell
added
the
community-contribution
| from cil.optimisation.functions import LeastSquares, L2NormSquared, ZeroFunction, ApproximateGradientSumFunction | ||
| from cil.framework import VectorData | ||
| import numpy as np | ||
| from cil.optimisation.utilities import RandomSampling |
Member
There was a problem hiding this comment.
Hi @epapoutsellis the unit tests are failing with:
from cil.optimisation.utilities import RandomSampling
ImportError: cannot import name 'RandomSampling' from 'cil.optimisation.utilities' (/opt/conda/lib/python3.11/site-packages/cil/optimisation/utilities/__init__.py)
Should it be this?
Suggested change
| from cil.optimisation.utilities import RandomSampling | |
| from cil.optimisation.utilities import RandomSampler |
Member
|
Thanks (again!) Vaggelis. A quick look I can see some easy memory saving changes. Maybe once unit tests pass I can make the changes directly before we merge? Is this referenced in the stochastic paper? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
close #2273
Example Usage
Contribution Notes
❤️ Thanks for your contribution!