spotify: added support for published and unpublished rootlist types, added addTrack, added createPlaylist, add addToRootList#85
Closed
niftylettuce wants to merge 1 commit intoTooTallNate:masterfrom
niftylettuce:master
Closed
spotify: added support for published and unpublished rootlist types, added addTrack, added createPlaylist, add addToRootList#85niftylettuce wants to merge 1 commit intoTooTallNate:masterfrom niftylettuce:master
niftylettuce wants to merge 1 commit intoTooTallNate:masterfrom
niftylettuce:master
Conversation
…added addTrack, added createPlaylist, add addToRootList
Author
|
$50-100+ bug bounty awarded to first person to find the solution, paid via PayPal or Gittip. |
|
@niftylettuce your code for the response from the request is essentially the request with a bunch of nonsense: With no songs actually being added to the playlist. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #24, I've refactored to master branch and tested.
For some reason the
playlisturireturned is not valid, e.g. when you docreatePlaylist('someuser', 'some playlist title', function(err, uri) {theurireturned looks likehm://playlist/user/someuserinstead ofhm://playlist/user/someuser/1234567. I can't figure out why it's not adding to root list... perhaps it's theaddRootListfunction?Hopefully one of you guys can help, this is troublesome for a newbie on this project.
I've tried to reference https://github.com/Hexxeh/spotify-websocket-api/blob/master/spotify_web/spotify.py#L583-L608 and the OP commits of #24, but I still can't resolve.
One thing I saw was that
proto/mercury.protospec has changed per the latest.xmlfile and you can see the diff I commented out inproto/mercury.protoper this commit/PR. SpecificallyMercuryRequesthas changed per https://github.com/Hexxeh/spotify-websocket-api/blob/master/spotify_web/proto/mercury.proto#L8-L13 and I'm wondering if this might have something to do with it?Let me know, thanks! /cc @TooTallNate @adammw