Add support for downloading remote images #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding additional expectingImage property to extraParams.
Add support for downloading remote images
Owner
|
Hi! Thanks for your contribution, it looks like this can be used for any filetype, not just images. Perhaps change it to a more generic implementation? |
Since responseData could be filetype other than image, let's use expectingFile instead (of expectingImage).
Add extraParams param to each method for error handling
Owner
|
Ok looking good! Could you bring in the changes in the recent update? Then I can go ahead and merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional expectingImage param for extraParams object.