Skip to content

Upstream Metatomic Model#523

Merged
CompRhys merged 8 commits intomainfrom
upstream-metatomic
Apr 2, 2026
Merged

Upstream Metatomic Model#523
CompRhys merged 8 commits intomainfrom
upstream-metatomic

Conversation

@CompRhys
Copy link
Copy Markdown
Member

@CompRhys CompRhys commented Mar 25, 2026

better branch name for #510. Waiting on 0.0.2 on https://pypi.org/project/metatomic-torchsim/

@CompRhys CompRhys linked an issue Mar 25, 2026 that may be closed by this pull request
@CompRhys CompRhys added the keep-open PRs to be ignored by StaleBot label Mar 25, 2026
@Luthaf
Copy link
Copy Markdown
Contributor

Luthaf commented Apr 2, 2026

The code has been released as v0.1.1! https://pypi.org/project/metatomic-torchsim/

@CompRhys
Copy link
Copy Markdown
Member Author

CompRhys commented Apr 2, 2026

Do you have a recommended model pt to use in testing here? I think the "pet-mad" keys no longer work with the new modularized packages. The ckpt from hugginface we used before needs more work to load into an AtomsiticModel

@CompRhys CompRhys merged commit dffc10f into main Apr 2, 2026
62 of 68 checks passed
@CompRhys CompRhys deleted the upstream-metatomic branch April 2, 2026 15:35
@Luthaf
Copy link
Copy Markdown
Contributor

Luthaf commented Apr 2, 2026

I was going to point you toward upet, but it looks like you already found it! We also have a toy model in https://github.com/metatensor/lj-test/ that is intended to be used in tests.

mattersim = ["mattersim>=0.1.2"]
metatomic = ["metatomic-torch>=0.1.3", "metatrain[pet]>=2025.12"]
orb = ["orb-models>=0.6.0"]
metatomic = ["metatomic-torchsim>=0.1.1", "metatomic-ase>=0.1.0", "upet>=0.2.0"]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea of metatomic/upet being separate packages is that some people will use other metatomic models that are not PET models, or not from the upet repository; so strictly speaking the upet dependency is not required here, except for testing purposes, but this is up to you!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the ase and upet to the same group for the purposes of having them installed for testing. Otherwise we would need to boost the number of extras groups 2x per model which seemed like a big step.

Maybe there's a way to do it with https://peps.python.org/pep-0723/ like we do for examples but I think we can come back to that at a later point?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the way this repository is setup, PEP 723 sounds like the best option yes! Otherwise we gave good success adding test-only dependencies to a tox environment specification. But this works for now!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the solution I would like doesn't yet exist there are no pep 723 aware test frameworks 🫠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keep-open PRs to be ignored by StaleBot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move Metatomic to external model posture

2 participants