fix(dice): clear roll interval on unmount (setState-after-unmount leak)#173
Merged
Conversation
… leak) Dice.roll() started a setInterval that fires setState every 100ms for 1s with no cleanup. A component unmounted mid-roll kept updating a dead component — a React "update on unmounted component" leak that surfaced as a nondeterministic coverage-teardown crash in CI (exit 1 after all tests pass; caught on the #168 run, unrelated to that change). Track the interval in a ref, clear it on unmount via useEffect, and clear any in-flight roll before starting a new one. Dice tests 14/14, type-check clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root-caused from a CI flake
Dice.roll()starts asetIntervalthat firessetStateevery 100ms for 1s, with no cleanup. A Dice component unmounted mid-roll keeps callingsetValue/setIsRollingon a dead component — a React "update on an unmounted component" leak.It surfaced as a nondeterministic coverage-teardown crash: the
Test (20.x)job exits 1 after printing "Tests 3614 passed", with a stack ending atDice.tsx:25inside aTimeout._onTimeoutduring React'sdispatchSetState. Timing-dependent, so it passed on recent main commits and flaked on an unrelated PR (#172).Fix
useRef, clear it on unmount viauseEffectcleanup.Dice tests 14/14, type-check clean. Small, isolated, kept out of the #168 monitor PR it flaked on.
🤖 Generated with Claude Code