fix(ci): #168 drop lighthouse:no-pwa preset (re-failed every main push)#174
Merged
Conversation
… push Follow-up to #172. Removing continue-on-error correctly surfaced a real problem: the post-merge lighthouse job failed on 82a69ea — but NOT at collect (the #172 URL fix worked, collect ran clean against all 3 URLs). It failed at ASSERT: the `lighthouse:no-pwa` preset ships error-level per-audit assertions (errors-in-console, valid-source-maps, legacy-javascript, forced-reflow-insight, ...) that fail on a perfectly healthy site — re-creating the exact "red check everyone ignores" this issue set out to kill. This monitor is a daily/push perf DASHBOARD (commits scores to docs/lighthouse-scores.json, runs on schedule + push-to-main), not a merge gate. So: drop the preset, keep only the four warn-level category assertions. Score regressions now surface as warnings in the log without failing the job; a genuine collect failure (site unreachable) still fails loudly because the step is no longer continue-on-error. Verified locally: `lhci assert --config=.github/lighthouse/lighthouserc.json` against the live site → exit 0, zero error-level failures (was six ✘ on the 82a69ea run). Refs #168 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #172 — the fix worked, and revealed the next layer
Removing
continue-on-errorin #172 did its job: the post-merge lighthouse run on82a69eafailed loudly instead of silently. But it failed at assert, not collect — the #172 URL fix worked (collect ran clean against all 3 URLs). Thelighthouse:no-pwapreset ships error-level per-audit assertions (errors-in-console,valid-source-maps,legacy-javascript,forced-reflow-insight, …) that fail on a perfectly healthy site — re-creating the exact "red check everyone ignores" #168 set out to kill. (I initially assumed our assertions were all warn-level; the preset overrode that — corrected here.)Fix
This monitor is a daily/push perf dashboard (commits scores to
docs/lighthouse-scores.json, runs on schedule + push-to-main), not a merge gate. Drop the preset; keep only the fourwarn-level category assertions. Score regressions surface as log warnings without failing the job; a genuine collect failure (site unreachable) still fails loudly (step is no longercontinue-on-error).Also gitignored
.lighthouseci/(local run artifacts).Verified
lhci assert --config=.github/lighthouse/lighthouserc.jsonagainst the live site → exit 0, zero error-level failures (was six ✘ on the82a69earun).Refs #168
🤖 Generated with Claude Code