test: remove two more vacuous integration tests (mock-only)#180
Merged
Conversation
…orts) auto-generation.test.ts (261 lines, 11 tests) and enhanced-processing.test.ts (637 lines, 21 tests) are the same false-coverage pattern as the migration test removed in #179: they import ZERO application source and assert against inline mock objects they define themselves (mockFileWatcher, local RemarkResult/ RehypeResult interfaces). They test the tests' own mocks, not the codebase — green regardless of what ships. Delete rather than keep coverage that guards nothing. This leaves src/tests/integration/ with only payment-isolation.test.ts, which is real (imports @/lib/supabase/types and exercises actual RLS behavior). Follow-up to #179 (flagged there as a scoping decision). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes
src/tests/integration/auto-generation.test.ts(261 lines, 11 tests) andenhanced-processing.test.ts(637 lines, 21 tests) — 898 lines of false-coverage tests.Why
Same pattern as the migration test removed in #179 (flagged there as a follow-up scoping decision): both files import zero application source and assert against inline mock objects they construct themselves (
mockFileWatcher, localRemarkResult/RehypeResultinterfaces). They test their own mocks, not the codebase — they pass regardless of what ships, so they imply coverage of a content-processing pipeline that isn't exercised at all.After this,
src/tests/integration/contains onlypayment-isolation.test.ts, which is a real test (imports@/lib/supabase/types, exercises actual RLS isolation).Verification
pnpm type-checkclean.vitest liststill collects the suite (3570 test descriptions).Follow-up to #179.
🤖 Generated with Claude Code