Regenerate Changelog on New Release#2500
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CodeQL flagged the single-pass strip of <!--...--> spans: crafted input like <!-<!-- x -->- y --> reconstructs <!-- after one replacement pass, and commit subjects reaching CHANGELOG.md are semi-untrusted PR titles. Drop comments only as whole lines, so removal can never concatenate fragments into a new <!--, and rely on the existing prose escaping to neutralize any remaining comment-like fragment as inert \<!-- text. Output for the current CHANGELOG.md is byte-identical, and adversarial payloads now compile as MDX with every < escaped outside code spans. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VzacCrozx56kZ3JpNCjKPv
|
@MarcusSorealheis Approved but appears to be a couple bugs via clanker review, #1 is most important Review: PR #2500 — "Regenerate Changelog on New Release" Findings, most severe first (all verified; several reproduced empirically against the real files and toolchain):
Checked and clean: the three marker lines exactly match today's cliff.toml output; the generated page from the real changelog has zero unescaped </{/} and no surviving HTML comments; turbo hashing of the out-of-root input works correctly when the file is on disk; the fail-loud fetch fallback is documented intended design (a verifier refuted "make it soft-fail" as contrary to the PR's stated contract — though the HTTP-error path's message could usefully repeat the Vercel-toggle instruction); and no CLAUDE.md governs the changed paths. One honorable mention that didn't make the cut: .github/workflows/web.yaml only builds on pull_request, so a changelog edit landing on main outside a PR is first validated by the production Vercel deploy itself. |
Description
Today, the Changelog in the docs site is frozen at 1.3.0. WE'd like for each release to be covered in accordance with the canonical changelog.
Fixes #2499
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
web && bunx turbo run build --filter=@nativelink/docs 2>&1 | tail -4Checklist
bazel test //...passes locallygit amendsee some docsThis change is