chore: remove dead internal/orders and internal/execution packages#24
Open
XelHaku wants to merge 1 commit into
Open
chore: remove dead internal/orders and internal/execution packages#24XelHaku wants to merge 1 commit into
XelHaku wants to merge 1 commit into
Conversation
Both packages were imported by nothing in the live Go path (internal/execution by nothing; internal/orders only by internal/execution). They also carried latent bugs (orders.ComputeAmounts ignored AmountUSDC; execution.PaperExecutor never debited cash and ignored price/postOnly). Removed both. Live order construction/signing lives in internal/clob; paper simulation in internal/paper (+ internal/workflows/paperaccount). Updated ARCHITECTURE.md, PRD.md, PRD_POLYDART.md, and POLYGOLEM-POLYDART-PARITY.md to drop the references and point at internal/clob / internal/paper, and to note Polydart now mirrors internal/clob for order math/signing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes two packages that were unused by the live Go path:
internal/execution— imported by nothing.internal/orders— imported only byinternal/execution(also removed).Both also carried latent bugs surfaced during the audit (
orders.ComputeAmountsignoredAmountUSDC→ zero-notional order;execution.PaperExecutornever debited cash and ignored price/postOnly). Rather than fix dead code, they're deleted.Live order construction + V2 deposit-wallet signing live in
internal/clob; paper simulation lives ininternal/paper(+internal/workflows/paperaccount).Docs updated (these packages were documented surfaces)
ARCHITECTURE.md— dropped the two package rows; live-execution path now listsinternal/clob.PRD.md— R5 (Order Builder) downgraded ✅→internal/clob); R6/R9 and package lists reworded to dropinternal/execution/internal/orders.PRD_POLYDART.md/POLYGOLEM-POLYDART-PARITY.md— Polydart now mirrorsinternal/clobfor order amount-math/signing (parity row points atinternal/clobhelpers + the golden test).Test Plan
go build ./...clean (nothing imported the removed packages)go vet ./...cleango test -short ./...passes🤖 Generated with Claude Code