Skip to content

Strip out unwanted hw midi ports from mod-host's JACK graph #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sastraxi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Strip out unwanted hw midi ports from mod-host's JACK graph #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions mod/host.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3633,6 +3633,9 @@ def load(self, bundlepath, isDefault=False, abort_catcher=None):
continue
self.msg_callback("add_hw_port /graph/%s midi 1 %s %i" % (symbol, name.replace(" ","_"), index))

if not self.midi_aggregated_mode:
self._disconnect_unwanted_hw_midi_ports()

instances = {
PEDALBOARD_INSTANCE: (PEDALBOARD_INSTANCE_ID, PEDALBOARD_URI)
}
Expand Down Expand Up @@ -6934,6 +6937,28 @@ def set_midi_devices_loopback_enabled(self, midi_loopback_enabled):
self.remove_port_from_connections(self.midi_loopback_port)
self.msg_callback("remove_hw_port /graph/midi_loopback")

# mod-host connects every physical MIDI capture port straight to its own midi_in on
# appearance (see ConnectToAllHardwareMIDIPorts/PortRegistration in mod-host), and
# mod-midi-merger appears to do the same for its own input -- neither has any concept
# of a device being excluded via our ports list, so an unchecked device must be
# disconnected after the fact rather than never connected in the first place.
def _disconnect_hw_port_from_host_midi_in(self, name):
disconnect_jack_ports(name, "mod-host:midi_in")
disconnect_jack_ports(name, "mod-midi-merger:in")

# Sweep every currently present hardware MIDI capture port and undo the host's/merger's
# auto-connect for any that aren't in the current enabled set. Needed at startup/load
# time because that auto-connect already ran before we ever get a chance to react to it.
def _disconnect_unwanted_hw_midi_ports(self):
enabled = set()
for port_symbol, _alias, _conns in self.midiports:
enabled.add(port_symbol.split(";", 1)[0] if ";" in port_symbol else port_symbol)

for name in get_jack_hardware_ports(False, False):
if name in enabled:
continue
self._disconnect_hw_port_from_host_midi_in(name)

# Will remove or add new JACK ports (in mod-ui) as needed
def set_midi_devices_separated(self, newDevs):
def add_port(name, title, isOutput):
Expand All @@ -6946,6 +6971,8 @@ def add_port(name, title, isOutput):
self.msg_callback("add_hw_port /graph/%s midi %i %s %i" % (name.split(":",1)[-1], int(isOutput), title, index))

def remove_port(name):
self._disconnect_hw_port_from_host_midi_in(name)

removed_conns = []

for ports in self.connections:
Expand Down