[WIP] Add basic support for sharing pedalboards via Patchstorage - #4
Open
rreichenbach wants to merge 2 commits into
Open
[WIP] Add basic support for sharing pedalboards via Patchstorage#4rreichenbach wants to merge 2 commits into
rreichenbach wants to merge 2 commits into
Conversation
…chooser page (currently Plugins or Pedalboards)
Collaborator
|
Looking good! Note for later: we'll have to rebase to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic support for sharing pedalboards.
Now, clicking the Patchstorage button redirects to an asset chooser page (Currently Plugins or Pedalboards).
Pedalboards found in the "Other Platforms" platform with a tag of "pistomp" will be shown. Eventually, we'll hopefully have a pi-Stomp platform. We have made the request. Then, we might need to qualify with a tag of "pedalboard".
Currently, you can filter the pedalboards, click on one to see its metadata and install it (download, then install). Eventually, we'd like to be able to upload from here to, but that requires that we authenticate (bearer token) with the users patchstorage creds, and collect the other fields (Description, version, license, etc.). We can probably auto extract the others (platform, tag(s), thumbnail, etc.)