fix: avoid unbound array expansion on macOS bash 3#14
Merged
Conversation
macOS runners ship bash 3.2, which errors on "${ARGS[@]}" when ARGS
is an empty array under set -u, breaking validate/diff/push/doc when
no values/set overrides are passed. Use the ${ARGS[@]+"${ARGS[@]}"}
guarded expansion so empty arrays produce zero arguments instead.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"${ARGS[@]}"as an unbound-variable error whenARGSis empty underset -u.validate/diff/push/docwhenever novalues/setoverrides were provided — surfaced by the new macOS smoke tests in fix: add CI, dependabot, and auto-release workflows #13.${ARGS[@]+"${ARGS[@]}"}expansion, which expands to nothing when the array is unset/empty rather than erroring.Linux runners (bash 5) are unaffected either way; this just makes the action work on macOS.
Test plan
smoke (macos-latest)job should pass