Collapsed eslint catalog + finalized flat-config migration#28826
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (27)
💤 Files with no reviewable changes (5)
✅ Files skipped from review due to trivial changes (11)
🚧 Files skipped from review as they are similar to previous changes (11)
WalkthroughThis PR updates workspace ESLint dependency management by bumping the shared Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx build @tryghost/signup-form |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/admin-toolbar |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/announcement-bar |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/portal |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/comments-ui |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/sodo-search |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/activitypub |
✅ Succeeded | 1s | View ↗ |
nx run @tryghost/admin-x-settings:test:acceptance |
✅ Succeeded | 9m 47s | View ↗ |
Additional runs (15) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-06-23 15:31:29 UTC
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Line 87: The `globals` dependency in package.json is using an inlined version
string instead of referencing the workspace catalog. Replace the inlined version
"17.6.0" with "catalog:" for the globals entry in package.json. Then add a
corresponding entry for globals in the `catalog:` section of pnpm-workspace.yaml
with the version pinned to "17.6.0" to follow the workspace catalog convention.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 332e5c47-c024-4b9e-947b-8725d1a1aff4
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (22)
apps/activitypub/package.jsonapps/admin-toolbar/package.jsonapps/admin-x-design-system/package.jsonapps/admin-x-framework/package.jsonapps/admin-x-settings/package.jsonapps/admin/package.jsonapps/announcement-bar/package.jsonapps/comments-ui/package.jsonapps/portal/package.jsonapps/posts/package.jsonapps/shade/package.jsonapps/signup-form/package.jsonapps/sodo-search/package.jsonapps/stats/package.jsoneslint.config.mjsghost/admin/package.jsonghost/core/package.jsonghost/i18n/package.jsonghost/parse-email-address/package.jsonpackage.jsonpnpm-workspace.yamlscripts/.eslintrc.js
💤 Files with no reviewable changes (1)
- scripts/.eslintrc.js
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28826 +/- ##
==========================================
- Coverage 74.10% 74.07% -0.03%
==========================================
Files 1560 1560
Lines 134883 134883
Branches 16335 16332 -3
==========================================
- Hits 99952 99912 -40
- Misses 33921 33991 +70
+ Partials 1010 980 -30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
9larsons
force-pushed
the
eslint9-10-catalog-collapse
branch
2 times, most recently
from
0721324 to
1dff46d
Compare
9larsons
changed the title
no ref - promoted eslint and @eslint/js (9.39.4) from the 'eslint9' named catalog into the default catalog in pnpm-workspace.yaml and removed the 'eslint9' block - swapped every 'catalog:eslint9' reference back to plain 'catalog:' across every workspace - added the root eslint.config.mjs covering scripts/ (replaces scripts/.eslintrc.js); added 'globals' to root devDeps as a peer for it - removed the dead legacy .eslintrc.cjs files in apps/admin-x-framework, apps/admin-x-design-system, and apps/shade — each was shadowed at runtime by its sibling eslint.config.js - restored the storybook recommended ruleset in apps/shade's flat config by spreading storybookPlugin.configs['flat/recommended']; the plugin was imported but its rules were never applied, leaving the 82 shade stories without storybook lint coverage. One now-redundant inline eslint-disable react-hooks/rules-of-hooks directive in icon.stories.tsx was dropped (the storybook stories-rules block disables it globally).
9larsons
force-pushed
the
eslint9-10-catalog-collapse
branch
from
1dff46d to
6330fde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eslintand@eslint/js(9.39.4) from theeslint9named catalog into the default catalog inpnpm-workspace.yamland removed theeslint9block.catalog:eslint9reference back to plaincatalog:across every workspace.eslint.config.mjscoveringscripts/(replacesscripts/.eslintrc.js); addedglobalsto root devDeps as a peer for it..eslintrc.cjsfiles inapps/admin-x-framework,apps/admin-x-design-system, andapps/shade— each was shadowed at runtime by its siblingeslint.config.js.apps/shade's flat config by spreadingstorybookPlugin.configs['flat/recommended']; the plugin was imported but its rules were never applied, leaving the 82 shade stories without storybook lint coverage. One now-redundant inlineeslint-disable react-hooks/rules-of-hooksdirective inicon.stories.tsxwas dropped (the storybook stories-rules block disables it globally).Test plan
pnpm exec eslint src/inapps/shade,apps/admin-x-framework,apps/admin-x-design-system— 0 errors