Improved internal package migration safeguards - #29842
Merged
Merged
Conversation
no ref The first cold-start migration exposed missing worktree, long-running subtree, dependency mapping and legacy package integration guidance. These checks make history imports safer without folding modernization into the ownership PR.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe migration skill now documents isolated checkouts, guarded history operations, consumer audits, dependency mapping, legacy package integration, and expanded pre-PR verification. The history reference adds subtree split, worktree, ancestry, and file-history checks. The legacy reference defines CommonJS integration and related configuration and validation steps. Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | <1s | View ↗ |
nx run-many -t lint -p ghost-monorepo |
✅ Succeeded | <1s | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-08-11 11:02:55 UTC
ErisDS
marked this pull request as ready for review
August 11, 2026 09:43
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/skills/migrate-internal-package/references/history-and-merge.md:
- Around line 7-25: After the git switch command in the history-splitting
instructions and before git subtree split, add a clean-working-tree check using
git status --porcelain that stops execution when any local changes remain.
- Around line 72-84: Make the topology-verification block self-contained by
accepting or assigning the recorded source split tip within this block rather
than relying on the earlier source_split_tip assignment. Enable fail-fast shell
execution with set -euo pipefail before the verification checks, preserving the
existing parent and ancestor validations and diagnostic commands.
- Around line 41-49: Update the dedicated Ghost worktree setup instructions
before the existing branch, cleanliness, base, and destination checks to
explicitly prove checkout isolation, either by adding a git worktree add step or
by asserting that git rev-parse --git-dir differs from git rev-parse
--git-common-dir; retain the existing validation checks afterward.
In @.agents/skills/migrate-internal-package/SKILL.md:
- Around line 53-60: Update the public-consumer audit guidance to require a
freshness or active-use signal before classifying Ghost forks or deployed
installation snapshots as having continued installation needs. Treat historical
presence alone as insufficient, and preserve the existing ownership decision and
escalation when current support expectations remain unclear.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 926f2d9f-4e7c-41f6-a72f-2eb8f2a4ac3a
📒 Files selected for processing (3)
.agents/skills/migrate-internal-package/SKILL.md.agents/skills/migrate-internal-package/references/history-and-merge.md.agents/skills/migrate-internal-package/references/legacy-integration.md
no ref Make the documented history checks fail closed and distinguish current consumer evidence from historical repository snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
git diff --checkpnpm lint:agent-skillsContext
The first end-to-end use of the migration skill exposed gaps around long-running
git subtree splitcommands, partially created worktrees, destination-base verification, sourceworkspace:*dependencies, and adapting a legacy CommonJS package without prematurely modernizing it.This PR updates the reusable workflow only. It does not migrate or modernize a package.