Removed ability to cancel in-progress email analytics jobs - #29869
Removed ability to cancel in-progress email analytics jobs#29869EvanHahn wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost:test:ci:integration |
✅ Succeeded | 3m | View ↗ |
nx run @tryghost/admin:test:acceptance |
✅ Succeeded | 7m 33s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 3m 6s | View ↗ |
nx run-many -t test:unit -p @tryghost/admin,ghost |
✅ Succeeded | 4m 39s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 3m 9s | View ↗ |
nx run ghost:test:e2e |
✅ Succeeded | 2m 42s | View ↗ |
nx run ghost-admin:test |
✅ Succeeded | 2m 58s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 21s | View ↗ |
Additional runs (3) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-08-11 17:07:24 UTC
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #29869 +/- ##
==========================================
+ Coverage 75.47% 75.48% +0.01%
==========================================
Files 1606 1606
Lines 140753 140702 -51
Branches 17458 17456 -2
==========================================
- Hits 106237 106213 -24
- Misses 33439 33441 +2
+ Partials 1077 1048 -29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d7e2c22 to
a246c4f
Compare
towards https://linear.app/ghost/issue/NY-1473 *I recommend reviewing this with whitespace changes disabled.* Scheduled email analytics jobs can be canceled from a hidden debug screen. Not only does this cancel future jobs, it also stops processing existing jobs. This has two disadvantages: - It makes the code more complex. - It relies on in-memory data, which we want to remove for statelessness purposes. Given that this can only be canceled from a debug view, let's remove this small but troublesome feature. I think this is a useful change on its own, but it'll make [an upcoming change][0] easier. [0]: https://linear.app/ghost/issue/NY-1473
a246c4f to
e4b23a5
Compare

towards https://linear.app/ghost/issue/NY-1473
I recommend reviewing this with whitespace changes disabled.
Scheduled email analytics jobs can be canceled from a hidden debug screen. Not only does this cancel future jobs, it also stops processing existing jobs.
This has two disadvantages:
Given that this can only be canceled from a debug view, let's remove this small but troublesome feature.
I think this is a useful change on its own, but it'll make an upcoming change easier.
Stack created with GitHub Stacks CLI • Give Feedback 💬