Skip to content

Removed the legacy Explore integration - #29880

Draft
ErisDS wants to merge 2 commits into
mainfrom
codex/remove-legacy-explore
Draft

Removed the legacy Explore integration#29880
ErisDS wants to merge 2 commits into
mainfrom
codex/remove-legacy-explore

Conversation

@ErisDS

@ErisDS ErisDS commented Aug 11, 2026

Copy link
Copy Markdown
Member

What changed

  • removed the old Ember Explore iframe route, modal, service, styles, and React fallback
  • removed the dedicated GET /ghost/api/admin/explore/ endpoint and backend service
  • removed the built-in Ghost Explore integration, API key, role, and permission from fixtures and existing installs via an idempotent migration
  • retained Explore Ping, its settings UI, Explore testimonials, and ghost-explore referral attribution

Testing

  • pnpm nx run ghost:build:tsc
  • pnpm nx run ghost-admin:lint
  • pnpm nx run ghost-admin:build
  • pnpm nx run @tryghost/admin:build
  • UPDATE_SNAPSHOT=1 pnpm test:single test/e2e-api/admin/roles.test.js
  • pnpm test:single test/unit/server/data/schema/integrity.test.js
  • pnpm exec vitest -c vitest.config.db.ts test/integration/migrations/migration.test.js --run
  • focused ESLint checks for changed Admin and Core files
  • migration verified against SQLite by running up twice and down once

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3039cba6-36b5-4176-a666-aead1ae77c89

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the migration [pull request] Includes migration for review label Aug 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

It looks like this PR contains a migration 👀
Here's the checklist for reviewing migrations:

General requirements

  • ⚠️ Tested performance on staging database servers, as performance on local machines is not comparable to a production environment
  • Satisfies idempotency requirement (both up() and down())
  • Does not reference models
  • Filename is in the correct format (and correctly ordered)
  • Targets the next minor version
  • All code paths have appropriate log messages
  • Uses the correct utils
  • Contains a minimal changeset
  • Does not mix DDL/DML operations
  • Tested in MySQL and SQLite

Schema changes

  • Both schema change and related migration have been implemented
  • For index changes: has been performance tested for large tables
  • For new tables/columns: fields use the appropriate predefined field lengths
  • For new tables/columns: field names follow the appropriate conventions
  • Does not drop a non-alpha table outside of a major version

Data changes

  • Mass updates/inserts are batched appropriately
  • Does not loop over large tables/datasets
  • Defends against missing or invalid data
  • For settings updates: follows the appropriate guidelines

@nx-cloud

nx-cloud Bot commented Aug 11, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit f28c732

Command Status Duration Result
nx run ghost:test:ci:integration ✅ Succeeded 3m 3s View ↗
nx run @tryghost/admin:test:acceptance ✅ Succeeded 7m 20s View ↗
nx run ghost:test:integration ✅ Succeeded 3m 10s View ↗
nx run-many -t test:unit -p @tryghost/admin,ghost ✅ Succeeded 4m 42s View ↗
nx run ghost:test:legacy ✅ Succeeded 2m 53s View ↗
nx run ghost:test:e2e ✅ Succeeded 2m 45s View ↗
nx run ghost-admin:test ✅ Succeeded 2m 47s View ↗
nx run ghost-monorepo:lint:boundaries ✅ Succeeded 22s View ↗
Additional runs (3) ✅ Succeeded ... View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-08-11 15:19:28 UTC

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.46%. Comparing base (95b89f6) to head (f28c732).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #29880      +/-   ##
==========================================
+ Coverage   75.42%   75.46%   +0.03%     
==========================================
  Files        1606     1594      -12     
  Lines      140657   140382     -275     
  Branches    17431    17377      -54     
==========================================
- Hits       106095   105934     -161     
+ Misses      33514    33379     -135     
- Partials     1048     1069      +21     
Flag Coverage Δ
admin-tests 56.39% <ø> (+0.41%) ⬆️
e2e-tests 77.54% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ErisDS added 2 commits August 11, 2026 16:05
no ref

Explore Ping replaced the iframe-based pull integration, so Ghost no longer needs to expose a dedicated Admin API endpoint or retain its long-lived built-in credential.
no ref

Removing the built-in Explore integration changed fixture counts and removed the endpoint used to verify core integration keys.
@ErisDS
ErisDS force-pushed the codex/remove-legacy-explore branch from fc41cd2 to f28c732 Compare August 11, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration [pull request] Includes migration for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant