Removed commentsThreads & commentsPinning labs flags - #29885
Conversation
Removes the permanently enabled `commentsThreads` labs flag now that threaded comments are generally available. Threading is the only rendering mode, so the flag's conditionals and the unreachable non-threaded UI (flat reply layout, reply-to snippets, top-level reply collapsing) are removed along with their translation keys.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughComment threading and comment pinning are always enabled. Labs flag checks and related prop branches were removed. Reply rendering, forms, focused-thread navigation, locators, pagination, permalinks, and tests were updated. Obsolete comment translations were removed. Comments UI version metadata was updated. Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🌐 Automated translation review
Verdict: ⏭️ Skipped — PR is too large for automated review
Reviewed 0 translations across 61 files.
This PR touches 61 translation files, which is beyond the automated reviewer's per-PR limit (max 15 files / 500 lines). A maintainer should review the translations manually.
Advisory review by i18n-review-bot. Non-blocking — a maintainer still owns the merge decision, and the bot cannot approve PRs on its own. Translator expertise wins where there is doubt.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85672d36bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
With threaded comments the only rendering mode, the prop no longer distinguishes threaded from non-threaded layouts — it distinguishes inline reply forms from the main top-of-thread form, so the name should say that.
There was a problem hiding this comment.
🌐 Automated translation review
Verdict: ⏭️ Skipped — PR is too large for automated review
Reviewed 0 translations across 61 files.
This PR touches 61 translation files, which is beyond the automated reviewer's per-PR limit (max 15 files / 500 lines). A maintainer should review the translations manually.
Advisory review by i18n-review-bot. Non-blocking — a maintainer still owns the merge decision, and the bot cannot approve PRs on its own. Translator expertise wins where there is doubt.
Removes the permanently enabled `commentsPinning` labs flag now that comment pinning is generally available. Pinned-first ordering and the pin moderation actions are unconditional, and the comments service no longer depends on labs at all since this was its only flag check.
kevinansfield
changed the title
There was a problem hiding this comment.
🌐 Automated translation review
Verdict: ⏭️ Skipped — PR is too large for automated review
Reviewed 0 translations across 61 files.
This PR touches 61 translation files, which is beyond the automated reviewer's per-PR limit (max 15 files / 500 lines). A maintainer should review the translations manually.
Advisory review by i18n-review-bot. Non-blocking — a maintainer still owns the merge decision, and the bot cannot approve PRs on its own. Translator expertise wins where there is doubt.
Matches the 'main' | 'reply' variant idiom already used by the comment components, instead of a boolean.
There was a problem hiding this comment.
🌐 Automated translation review
Verdict: ⏭️ Skipped — PR is too large for automated review
Reviewed 0 translations across 61 files.
This PR touches 61 translation files, which is beyond the automated reviewer's per-PR limit (max 15 files / 500 lines). A maintainer should review the translations manually.
Advisory review by i18n-review-bot. Non-blocking — a maintainer still owns the merge decision, and the bot cannot approve PRs on its own. Translator expertise wins where there is doubt.
kevinansfield
changed the title
…eads-flag # Conflicts: # ghost/core/core/shared/labs.js
…inor Removing the commentsThreads GA flag from the backend would regress any already-deployed comments-ui 1.5.x bundle, which still reads labs.commentsThreads from the settings endpoint and falls back to the flat layout when it is absent. Publishing the flag-free comments-ui as 1.6.0 and pointing Ghost's default asset config at ~1.6 keeps old backends paired with old bundles and new backends with new bundles, so neither side ever sees the mismatched combination.
There was a problem hiding this comment.
🌐 Automated translation review
Verdict: ⏭️ Skipped — PR is too large for automated review
Reviewed 0 translations across 61 files.
This PR touches 61 translation files, which is beyond the automated reviewer's per-PR limit (max 15 files / 500 lines). A maintainer should review the translations manually.
Advisory review by i18n-review-bot. Non-blocking — a maintainer still owns the merge decision, and the bot cannot approve PRs on its own. Translator expertise wins where there is doubt.
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost:test:ci:integration |
✅ Succeeded | 3m 1s | View ↗ |
nx run @tryghost/admin:test:acceptance |
✅ Succeeded | 6m 23s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 2m 2s | View ↗ |
nx run-many -t test:unit -p @tryghost/admin,@tr... |
✅ Succeeded | 3m 50s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 3m | View ↗ |
nx run ghost:test:e2e |
✅ Succeeded | 1m 54s | View ↗ |
nx run ghost-monorepo:lint:boundaries |
✅ Succeeded | 23s | View ↗ |
nx run-many -t lint -p @tryghost/admin,@tryghos... |
✅ Succeeded | 1m 51s | View ↗ |
Additional runs (4) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-08-11 16:03:55 UTC
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29885 +/- ##
==========================================
- Coverage 75.49% 75.48% -0.01%
==========================================
Files 1606 1606
Lines 140794 140778 -16
Branches 17464 17457 -7
==========================================
- Hits 106291 106267 -24
- Misses 33426 33463 +37
+ Partials 1077 1048 -29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
Removes the permanently enabled
commentsThreadsandcommentsPinninglabs flags now that threaded comments and comment pinning are generally available.Because both flags were GA (always on), everything they gated was dead code in production.
commentsThreads — the
useThreadingprop threaded through every comments-ui component and all of the non-threaded rendering branches are removed: the flat reply layout, the "Replied to:" reply snippets, and top-level reply collapsing were unreachable in production.FormWrapper'sthreadedLayoutprop is replaced bylayoutVariant: 'main' | 'reply'since it now distinguishes inline reply forms from the main form rather than threaded from non-threaded. Unused translation keys are pruned from all locales.commentsPinning — pinned-first ordering and the pin moderation actions are now unconditional across the comments service, Admin, and comments-ui. The 405 "pinning not enabled" guard is removed, and since that was the comments service's only labs check, the service's labs dependency is removed entirely.
The comments-ui e2e suite previously defaulted the mocked flags off and so was exercising the non-threaded UI production users never saw; tests for removed behaviour are deleted and the threading tests move from
labs.test.tsto a newthreads.test.ts.Deploy ordering — comments-ui is bumped to 1.6.0 with Ghost's default asset config pointing at
~1.6, so already-deployed backends keep pairing with 1.5.x bundles (which still read the flag) and flag-free backends only ever load flag-free bundles.