Skip to content

Tested email analytics initializer - #29892

Open
EvanHahn wants to merge 10 commits into
data-db-typesfrom
email-analytics-init-di-and-test
Open

Tested email analytics initializer#29892
EvanHahn wants to merge 10 commits into
data-db-typesfrom
email-analytics-init-di-and-test

Conversation

@EvanHahn

@EvanHahn EvanHahn commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

no ref

I recommend reviewing this one commit at a time.

This change should have no user impact.

This change:

  • tests the email analytics initializer
  • stops using global references and injects the dependencies (DI)

In addition to automated testing, I also manually tested this. I sent a newsletter, opened it in Gmail, and verified that I saw the open appear in the newsletter's analytics.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ff30bce0-06bc-4c3c-8d70-d85ea3aba9e1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Aug 11, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit b769f91

Command Status Duration Result
nx run ghost:test:ci:integration ✅ Succeeded 2m 25s View ↗
nx run ghost:test:integration ✅ Succeeded 3m 22s View ↗
nx run ghost:test:e2e ✅ Succeeded 2m 50s View ↗
nx run ghost:test:legacy ✅ Succeeded 2m 55s View ↗
nx run-many -t test:unit -p ghost ✅ Succeeded 30s View ↗
nx run ghost-monorepo:lint:boundaries ✅ Succeeded 20s View ↗
nx run-many -t lint -p ghost,ghost-monorepo ✅ Succeeded 18s View ↗
nx run @tryghost/admin:build ✅ Succeeded 7s View ↗
nx run-many --target=build --projects=tag:publi... ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-08-11 20:54:38 UTC

@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.47%. Comparing base (8a4cd7e) to head (b769f91).

Files with missing lines Patch % Lines
...email-analytics/email-analytics-service-wrapper.js 74.41% 10 Missing and 1 partial ⚠️
...core/core/server/services/email-analytics/index.ts 98.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           data-db-types   #29892   +/-   ##
==============================================
  Coverage          75.46%   75.47%           
==============================================
  Files               1607     1607           
  Lines             140789   140879   +90     
  Branches           17465    17468    +3     
==============================================
+ Hits              106247   106327   +80     
+ Misses             33494    33474   -20     
- Partials            1048     1078   +30     
Flag Coverage Δ
e2e-tests 77.62% <90.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EvanHahn
EvanHahn requested a review from cmraible August 11, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant