fix: add min-width to LinkInput fallback for usable link editing#1995
Open
Dikshant0Git wants to merge 2 commits into
Open
fix: add min-width to LinkInput fallback for usable link editing#1995Dikshant0Git wants to merge 2 commits into
Dikshant0Git wants to merge 2 commits into
Conversation
The LinkInput component is the fallback used when cardConfig.searchLinks is unavailable (e.g., feature image caption editor). Without a min-width, it shrinks to content size and becomes unusably small. Adding min-w-[240px] ensures the link input is always wide enough to comfortably view and edit URLs, even in contexts where the full LinkInputWithSearch is not available. refs TryGhost/Ghost#22067
WalkthroughThe Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LinkInput component is the fallback used when cardConfig.searchLinks is unavailable (e.g., feature image caption editor). Without a min-width, it shrinks to content size and becomes unusably small.
Adding min-w-[240px] ensures the link input is always wide enough to comfortably view and edit URLs, even in contexts where the full LinkInputWithSearch is not available.
refs TryGhost/Ghost#28359