Skip to content

feat(2571): DMs for desktop#3263

Open
islathehut wants to merge 161 commits into
developfrom
feat/2571-private-dms-desktop
Open

feat(2571): DMs for desktop#3263
islathehut wants to merge 161 commits into
developfrom
feat/2571-private-dms-desktop

Conversation

@islathehut

@islathehut islathehut commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Checklist

  • I have linked this PR to a related GitHub issue.
  • I have added a description of the change (and Github issue number, if any) to the root CHANGELOG.md.

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

islathehut and others added 30 commits January 12, 2026 09:32
…nit since we can start initialization via qss or libp2p events
@islathehut islathehut requested review from adrastaea, holmesworcester and mcginty and removed request for adrastaea and mcginty June 18, 2026 15:59
@holmesworcester

Copy link
Copy Markdown
Collaborator

I'm trying to figure out if the "ID deterministic from participants" is a good idea. Some thoughts:

  1. We can always enforce "same DM" in the frontend without making the ID the same.

  2. Enforcing it in the backend by making ID deterministic from members would be helpful for concurrency (Alice and Bob both create a Alice, Bob, Carol DM) but we'll have different keys anyway, and different roles, is this too weird?

I think what happens is, right now you'll essentially have n (concurrent DM creation) different cryptographic/role contexts for the same channel id, and all messages will be visible. Is that right? That gives everyone the properties they want at this stage, or seems to!

@islathehut can you vouch for this making sense and behaving well in the concurrent case?

How do you feel about random id's and frontend-only enforcement of "same members, same DM channel"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User should be able to start group DMs

2 participants