Conversation
There was a problem hiding this comment.
Pull request overview
Updates miniGU Lab 2 documentation to direct learners to run the lab verification via Rust integration tests in minigu-gql, instead of older unit-test instructions.
Changes:
- Replaces “单元测试” sections with “集成测试” in Lab 2-1 / 2-2 / 2-3 docs.
- Updates
cargo testcommands to run the specific--test ...integration test targets and individual test cases.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/minigu/labs/lab2-1.md | Switches Lab 2-1 verification to minigu-gql integration tests and updates example commands. |
| docs/minigu/labs/lab2-2.md | Switches Lab 2-2 verification to minigu-gql integration tests and updates example commands. |
| docs/minigu/labs/lab2-3.md | Switches Lab 2-3 verification to minigu-gql integration tests and updates example commands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| cargo test -p minigu-gql --test lab3_optimizer_test | ||
|
|
||
| # 运行谓词下推测试 | ||
| cargo test -p minigu-planner test_predicate_pushdown | ||
| # 运行特定测试 | ||
| cargo test -p minigu-gql --test lab3_optimizer_test test_id_predicate_pushdown |
There was a problem hiding this comment.
These cargo test -p minigu-gql ... commands need to be run from the labs/miniGU workspace (or via --manifest-path labs/miniGU/Cargo.toml). Please add that prerequisite here so readers can run the commands successfully from a fresh shell.
| # 运行 Lab 2-1 的集成测试 | ||
| cargo test -p minigu-gql --test lab2-1_executor_test | ||
|
|
||
| # 运行特定测试 | ||
| cargo test -p minigu-execution test_expand_executor | ||
| cargo test -p minigu-execution test_project_executor | ||
| cargo test -p minigu-gql --test lab2-1_executor_test test_project_single_column | ||
| cargo test -p minigu-gql --test lab2-1_executor_test test_expand_outgoing |
There was a problem hiding this comment.
These cargo test -p minigu-gql ... commands only work when run from the labs/miniGU Cargo workspace (there’s no Cargo.toml at repo root). Please update the instructions to either cd labs/miniGU before running tests or use cargo test --manifest-path labs/miniGU/Cargo.toml ... so they work from any directory.
| # 运行 Lab 2-2 的集成测试 | ||
| cargo test -p minigu-gql --test lab2-2_filter_test | ||
|
|
||
| # 运行特定测试 | ||
| cargo test -p minigu-planner test_plan_match_with_filter | ||
| cargo test -p minigu-gql --test lab2-2_filter_test test_basic_where_clause |
There was a problem hiding this comment.
These cargo test -p minigu-gql ... commands assume you are already in the labs/miniGU Cargo workspace. Since the repo root doesn’t contain a Cargo.toml, please add an explicit cd labs/miniGU (or use --manifest-path labs/miniGU/Cargo.toml) in this test section so the commands work when followed verbatim.
| ```bash | ||
| # 运行优化器测试 | ||
| cargo test -p minigu-planner test_optimizer --no-fail-fast | ||
| # 运行 Lab 3 优化器测试 |
There was a problem hiding this comment.
The comment says “运行 Lab 3 优化器测试”, but this is Lab 2-3’s doc and the test file is named lab3_optimizer_test. To avoid confusion, please align the wording (e.g., “Lab 2-3 优化器测试”) or explicitly explain why this is called “Lab 3”.
| # 运行 Lab 3 优化器测试 | |
| # 运行 Lab 2-3 优化器测试 |
No description provided.