-
Notifications
You must be signed in to change notification settings - Fork 37
Add more logging for run_ad
#1168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Benchmark Report
Computer InformationBenchmark Results |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1168 +/- ##
===========================================
- Coverage 80.01% 35.34% -44.67%
===========================================
Files 41 41
Lines 3877 3907 +30
===========================================
- Hits 3102 1381 -1721
- Misses 775 2526 +1751 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6d8aec2 to
5560f43
Compare
|
DynamicPPL.jl documentation for PR #1168 is available at: |
5560f43 to
c5f91b0
Compare
c5f91b0 to
5fb628c
Compare
5fb628c to
1b0e43b
Compare
mhauru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
(CI failures are unrelated) |
Closes #1166. Example code which you can run is here. On main, these will both print out gigantic ugly structs using their default display methods.
The successful test now outputs the following. The lines up until ADResult are logging generated during the call itself (which can be disabled with
verbose=true), after that it's the display method of theADResultstruct.This is the failing test, it now tells you how much of an atol/rtol you need to make it pass, which is really useful for figuring out whether you have a serious correctness issue, or whether finite differences are just a bit inaccurate (I've needed to do this for ADTests a few times).