-
Notifications
You must be signed in to change notification settings - Fork 37
Remove vector_getranges, vector_getrange, and getranges
#1175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Benchmark Report
Computer InformationBenchmark Results |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1175 +/- ##
===========================================
+ Coverage 35.34% 78.95% +43.60%
===========================================
Files 41 41
Lines 3907 3896 -11
===========================================
+ Hits 1381 3076 +1695
+ Misses 2526 820 -1706 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mhauru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good if tests pass
All of these functions were used to identify which part of a flattened parameter vector belonged to a particular VarName. In a happy coincidence, it turned out that I reinvented this wheel as part of FastLDF, so we can now get rid of these and just directly check the LDF's internal fields (not ideal, but it's contained within DPPL so not too bad, and I'm not keen to expose a public interface to this NT + Dict hydra).