Implement type consistent ancestor callback #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at solving #124.
I think this is probably the cleanest approach without forcing the initial and following states to be of the same type.
I've only implemented the dense ancestor callback for now. Will also do sparse if @charlesknipp likes these changes.
I'm not sure this is a good idea to make all callbacks behave like this in general. For example, the GPU version of this should really store everything a big N x (K+1) array so we would need to force constant types in that case.
For the CPU case though, I think it's reasonable to allow different types.