trying pull request #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tushar-OP
reviewed
Feb 12, 2019
Tushar-OP
requested changes
Feb 12, 2019
Owner
Tushar-OP
left a comment
Tushar-OP
left a comment
There was a problem hiding this comment.
Some Errors Correct them and try again!
Tushar-OP
requested changes
Feb 12, 2019
|
|
||
|
|
||
| endwith(str1,str2) | ||
|
|
Owner
There was a problem hiding this comment.
This checks only if the the string 1 ends with string 2, What if the str 1 is abc and string 2 is abXabc?
| @@ -47,6 +47,9 @@ def arrayCheck(nums): | |||
| # stringBits('Heeololeo') → 'Hello' | |||
|
|
|||
Part-1-Functions
Outdated
| c = c + char*2 | ||
| return print(c) | ||
|
|
||
| double(str) |
Owner
There was a problem hiding this comment.
Call doubleChar! not double atleast run before pulling
| return print(c) | ||
|
|
||
| double(str) | ||
| # CODE GOES HERE |
Owner
There was a problem hiding this comment.
Dude stop using keyword 'str' its an inbuilt keyword, excluding this changes the function is correct
Part-1-Functions
Outdated
| count=count+1 | ||
| else: | ||
| i=i+1 | ||
| print(count) |
Owner
There was a problem hiding this comment.
No need of i=i+1 just do count no need of else as we have to count only even numbers!
| return print(str[::2]) | ||
|
|
||
| stringBits(str) | ||
| # CODE GOES HERE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry