perf(test): run release sandbox tests from a tiny fixture dir#827
Merged
Conversation
release::sandbox::create tars $(pwd), so the 6 calls in release_sandbox_test.sh each copied the ~21MB repo into /tmp, making it the slowest unit file (~5.8s). Build a few-KB fake project (bashunit, build.sh, CHANGELOG.md, .git/, .release-state/) once per script and cd there instead: ~5.8s -> ~0.9s, and the exclusion tests no longer depend on the real repo's state. The fixture uses bashunit::temp_dir rather than a manual mktemp + tear_down_after_script: in parallel mode workers start before the file-level teardown runs, so a manual rm -rf raced the workers and silently dropped 5 tests under --parallel --strict. Closes #825
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #825
release::sandbox::createtars the current working directory, so the 6 calls inrelease_sandbox_test.sheach copied the ~21MB repo into /tmp, making it the slowest unit test file (~5.8s).💡 Changes
.git/and.release-state/, so the exclusion tests no longer depend on the real repo's statebashunit::temp_dir(framework-cleaned after workers finish) — a manualrm -rfintear_down_after_scriptraces parallel workers, which start before file-level teardownrelease.shhttps://claude.ai/code/session_01JSeB8UzLCpqst55hAK6dED