perf(test): mock measure_ms in assert_duration failure paths#828
Merged
Conversation
The three failure-path tests only exercise the threshold comparison and the failure message, yet each paid a real 'sleep 1' — 3s of the file's 3.3s runtime. Mock bashunit::duration::measure_ms (heredoc form, so call args are not appended to the fake reading) and assert against fake commands instead: ~3.3s -> ~0.4s. One success path keeps a real short sleep so measure_ms integration stays covered end-to-end, guarded to skip under the last-resort date-seconds clock whose 1s resolution would read 'sleep 0.2' as 0ms. Closes #826
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #826
The three failure-path tests in
assert_duration_test.sheach paid a realsleep 1— 3s of the file's 3.3s runtime — only to exercise the threshold comparison and failure message.💡 Changes
bashunit::duration::measure_ms(heredoc form, so call args aren't appended to the fake reading) in failure-path tests: ~3.3s → ~0.4smeasure_msintegration stays covered end-to-enddate-secondsclock, whose 1s resolution would readsleep 0.2as 0mssrc/https://claude.ai/code/session_01JSeB8UzLCpqst55hAK6dED