Skip to content

Conversation

@tom-ridsdale
Copy link
Contributor

@tom-ridsdale tom-ridsdale commented Dec 9, 2025

Migrated the @typeform/api-client repository from classic NPM_TOKEN authentication to npm's Trusted Publishers (OIDC) authentication.

Updated branch protection rules

  • Removed:
    • build-lint-test - node 18
    • build-lint-test - node 20
  • Added:
    • build-lint-test - node 22

Node Version Strategy

Build/CI (Node 22):

  • Release workflow and PR tests use Node 22
  • Required by @semantic-release/npm ^13.1.1 for OIDC support
  • Dev dependencies cannot be installed on older Node versions

Runtime (Node >=12):

  • engines.node remains at >=12 for user compatibility

Changes made:

  1. Upgraded dependencies (package.json)
  • @semantic-release/npm: ^11.0.1^13.1.1
  • This version adds OIDC support and provenance attestation
  1. Updated Release workflow
  • Upgraded Node.js: 20 → 22 (required for @semantic-release/npm ^13.1.1)
  • Added OIDC permissions: id-token: write and contents: write
  • Removed things related to NPM_TOKEN authentication
  1. Enabled provenance (.releaserc)
  • Enables automatic provenance attestation for published packages
  1. Added Node 22 to test matrix (.github/workflows/pr.yml)
  • PR workflow now only tests Node 22
  • Coverage uploaded from Node 22

@@ -7,6 +7,34 @@
resolved "https://registry.yarnpkg.com/@aashutoshrathi/word-wrap/-/word-wrap-1.2.6.tgz#bd9154aec9983f77b3a034ecaa015c2e4201f6cf"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lots of changes here 🫠

@tom-ridsdale tom-ridsdale changed the title feat(TU-33147): changes required to use OIDC authentication feat(TU-33147): Migrate to OIDC Authentication Dec 9, 2025
@tom-ridsdale
Copy link
Contributor Author

Built and tests ran successfully locally.
Not sure if there's any manual testing I can do to verify it's all okay 🤔 - I am not familiar with this repo

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

@tom-ridsdale tom-ridsdale marked this pull request as ready for review December 9, 2025 12:52
@tom-ridsdale tom-ridsdale requested a review from a team as a code owner December 9, 2025 12:52
@gitstream-cm
Copy link

gitstream-cm bot commented Dec 9, 2025

🥷 Code experts: robespmun

robespmun has most 👩‍💻 activity in the files.
robespmun has most 🧠 knowledge in the files.

See details

.github/workflows/pr.yml

Activity based on git-commit:

robespmun
DEC
NOV
OCT
SEP
AUG
JUL 98 additions & 0 deletions

Knowledge based on git-blame:
robespmun: 100%

.github/workflows/release.yml

Activity based on git-commit:

robespmun
DEC
NOV
OCT
SEP
AUG
JUL 50 additions & 0 deletions

Knowledge based on git-blame:
robespmun: 100%

.releaserc

Activity based on git-commit:

robespmun
DEC
NOV
OCT
SEP
AUG
JUL 30 additions & 0 deletions

Knowledge based on git-blame:
robespmun: 100%

package.json

Activity based on git-commit:

robespmun
DEC
NOV
OCT
SEP
AUG
JUL 115 additions & 0 deletions

Knowledge based on git-blame:
robespmun: 99%

yarn.lock

Activity based on git-commit:

robespmun
DEC
NOV
OCT
SEP
AUG
JUL 13822 additions & 0 deletions

Knowledge based on git-blame:
robespmun: 99%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

@tom-ridsdale tom-ridsdale merged commit 979616e into main Dec 9, 2025
15 checks passed
@tom-ridsdale tom-ridsdale deleted the feat/TU-33147 branch December 9, 2025 14:10
@typeform-ops-gha
Copy link

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants