Fix timestamps #508
Draft
Fix timestamps #508
+11
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1dedfb1. Such files exist in the wild (one example being a large set of old CR rips, see https://redvice.org/2018/crunchyroll-83ms-delay/) and players like mpv also respect this video delay (at least they do now, they might not have when the linked commit was made). Fixes TypesettingTools#21. Fixes TypesettingTools#169.
I believe mpv calculate the time of each frame like this (I have no proof) ``` time_of_frame_x = (time_of_frame_x - time_of_frame_0) + (AVStream::start_time - AVFormatContext::start_time) ``` In ffms2 case, I think `time_of_frame_0` is always equals to `AVStream::start_time` (this might not be the case!!!) and they are represented by `FFMS_VideoProperties::FirstTime`. Fix arch1t3cht#172
Contributor
Author
Actually, yes and no. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe mpv calculate the time of each frame like this (I have no proof)
In ffms2 case, I think
time_of_frame_0is always equals toAVStream::start_time(this might not be the case!!!) and they are represented byFFMS_VideoProperties::FirstTime.This PR is a draft because i'm not sure that this properly emulate how mpv works.
I just wanted to show you a possible fix.
Fix #172