Skip to content

Fix umask configuration to enable group-writable files #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kurowski merged 5 commits into from
Jan 14, 2026
+8 −1
Merged

Fix umask configuration to enable group-writable files #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b166aa
Initial plan
Copilot Jan 13, 2026
feb7e12
Add temporary workaround and fix umask in Dockerfile
Copilot Jan 13, 2026
b86d5f6
Improve comment for temporary workaround
Copilot Jan 13, 2026
67e626a
Use pam_umask instead of /etc/login.defs for umask setting
Copilot Jan 13, 2026
6a7cb83
Simplify pam_umask sed pattern for better robustness
Copilot Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
FROM mcr.microsoft.com/devcontainers/php:8.3

# Change default umask and add user to web group so we can share write permission on web files
RUN sed -i 's/^UMASK\s*022/UMASK 002/' /etc/login.defs
# Configure pam_umask to set umask to 002 (works regardless of /etc/login.defs content)
RUN sed -i 's/pam_umask\.so/pam_umask.so umask=002/' /etc/pam.d/common-session \
&& sed -i 's/pam_umask\.so/pam_umask.so umask=002/' /etc/pam.d/common-session-noninteractive
RUN usermod -aG www-data vscode

# Add glow for formatting command usage output (and because it's just nice)
Expand Down Expand Up @@ -57,6 +59,9 @@ RUN sed -i 's/Listen\s*80$/# Listen 80/' /etc/apache2/ports.conf
# Enable Apache modules
RUN a2enmod expires headers rewrite

# Set umask for Apache to ensure group-writable files
RUN echo "umask 002" >> /etc/apache2/envvars

# Install terminus
RUN curl -L https://github.com/pantheon-systems/terminus/releases/latest/download/terminus.phar --output /usr/local/bin/terminus \
&& chmod +x /usr/local/bin/terminus \
Expand Down
2 changes: 2 additions & 0 deletions local/etc/uceap.d/refresh_content.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ function refresh_content() {
# no-same-permissions doesn't seem to work so we fix it here
sudo find web/sites/default/files -type d -exec chmod g+ws {} +
sudo find web/sites/default/files -type f -exec chmod g+w {} +
# TODO: Temporary workaround for umask issue - remove once Dockerfile umask fix is verified
chmod -R g+w web/sites/default/files

db-rebuild.sh $DATABASE_BACKUP

Expand Down