Change PinholeSPECTUB global variables to class members#1212
Merged
KrisThielemans merged 2 commits intoUCL:masterfrom Jun 3, 2023
Merged
Change PinholeSPECTUB global variables to class members#1212KrisThielemans merged 2 commits intoUCL:masterfrom
KrisThielemans merged 2 commits intoUCL:masterfrom
Conversation
KrisThielemans
approved these changes
Jun 3, 2023
Collaborator
KrisThielemans
left a comment
KrisThielemans
left a comment
There was a problem hiding this comment.
gcc-12 ubuntu failure is unrelated to this PR. Hopefully it'll be resolved by #1213
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1211 by changing global variables to class members. Info added to
release_5.2.htm.See #1169 for further discussion made during removal of global variables for SPECTUB.
All tests pass in
recon_test_pack/SPECT/PinholeSPECT/and SIRF allows multiple projectors with PinholeSPECTUBMatrix.