TOF mashing = TOF bins fixes#1434
Closed
KrisThielemans wants to merge 2 commits intoUCL:modifications_for_psmr2024from
Closed
TOF mashing = TOF bins fixes#1434KrisThielemans wants to merge 2 commits intoUCL:modifications_for_psmr2024from
KrisThielemans wants to merge 2 commits intoUCL:modifications_for_psmr2024from
Conversation
Collaborator
Author
|
Obsolete as all fixed in #1430 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@NikEfth As per my review. I need these changes to all tests to work. In addition, the code should still do what you want it to.
One particular change that I need is in
ProjDataInfo::get_tof_binwhere we can no longer check onis_tof_data, as when that isfalse, it goes into the next part of the code, but that fails as the relevant arrays are not set-up.Sorry for the white-space changes, but this is due to precommit. If you're running Ubuntu 22.04, consider installing
clang-formatandpre-commitas https://github.com/UCL/STIR/blob/master/documentation/devel/git-hooks.md