Skip to content

Enhanced docstrings for plotting and visualization functions#38

Merged
haileyajohnson merged 7 commits intoUCSD-SIO-CDIP:mainfrom
Iqbal-dev12:add-plotting-docs
Oct 7, 2025
Merged

Enhanced docstrings for plotting and visualization functions#38
haileyajohnson merged 7 commits intoUCSD-SIO-CDIP:mainfrom
Iqbal-dev12:add-plotting-docs

Conversation

@Iqbal-dev12
Copy link
Contributor

@Iqbal-dev12 Iqbal-dev12 commented Oct 6, 2025

This Pull Request adds enhanced docstrings and usage examples for all plotting/visualization methods in CDIPpy as described in Issue #21.

Changes included:

  • Added detailed parameter descriptions and return types.
  • Added example usage for make_annual_hs_boxplot, make_compendium_plot, and make_sst_climatology_plot.
  • Improved consistency across all plotting function docstrings.

This makes the documentation clearer and helps users understand how to use the plotting functions effectively.

@haileyajohnson
Copy link
Member

Thank you for the docstrings but please remove the examples referencing a different library.

@haileyajohnson haileyajohnson changed the title Enhanced documentation for plotting and visualization functions #23Add plotting docs Enhanced docstrings for plotting and visualization functions Oct 6, 2025
@Iqbal-dev12
Copy link
Contributor Author

Thank you for the docstrings but please remove the examples referencing a different library.

Check it as I have updated the latest commit without examples

Copy link
Member

@haileyajohnson haileyajohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great docstrings, thank you! Would you mind reformatting them to google style to match the rest of the projects? I think it it just changing "Parameters" to "Args" and removing the dashed underline.

@Iqbal-dev12
Copy link
Contributor Author

Great docstrings, thank you! Would you mind reformatting them to google style to match the rest of the projects? I think it it just changing "Parameters" to "Args" and removing the dashed underline.

I have updated them to google style check for my latest commit...Thank You

Copy link
Member

@haileyajohnson haileyajohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

Iqbal-dev12 and others added 7 commits October 7, 2025 11:50
The docstrings for plotting functions previously included example sections 
that referenced external libraries and interactive code (e.g., matplotlib 
usage with fig.show()). These examples were removed to keep the 
documentation clean, consistent, and focused only on parameters 
and return values.

This improves clarity and avoids confusion for users while maintaining 
a standard NumPy-style docstring format across the module.
Updated all function docstrings in plotting.py to follow Google-style formatting for consistency with the rest of the project. 
Removed the previous NumPy-style section headers ("Parameters", "Returns") and replaced them with "Args" and "Returns" blocks. 
Also ensured that no external or unrelated library references remain.
@haileyajohnson haileyajohnson merged commit ea86eb1 into UCSD-SIO-CDIP:main Oct 7, 2025
4 checks passed
@Iqbal-dev12 Iqbal-dev12 deleted the add-plotting-docs branch October 11, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments