Skip to content

[MA-547] Implement card view analytics#2287

Closed
hamedhemmati wants to merge 0 commit intoexperimentalfrom
hamed-analytics
Closed

[MA-547] Implement card view analytics#2287
hamedhemmati wants to merge 0 commit intoexperimentalfrom
hamed-analytics

Conversation

@hamedhemmati
Copy link
Copy Markdown
Collaborator

Need to run some test on this analytics wrapper to see if data collection is working and if it's tagging them correctly.

@hamedhemmati hamedhemmati self-assigned this Jan 29, 2026
angelawu236
angelawu236 previously approved these changes Feb 5, 2026
@hamedhemmati hamedhemmati dismissed angelawu236’s stale review February 5, 2026 19:01

The merge-base changed after approval.

angelawu236
angelawu236 previously approved these changes Feb 5, 2026
@github-actions
Copy link
Copy Markdown

Code Style Violations Found

  • Very Long If Statement Conditions: 1 violations

Total Violations: 1
Total Categories Failed: 1/6

Here are the formatting rules to follow:

  • Static Constants have to use UPPER_SNAKE_CASE (e.g., MAX_RETRY_COUNT)
  • Classes have to use UpperCamelCase (e.g., UserProfile)
  • Variables/Functions have to use lowerCamelCase (e.g., userName)
  • Files/Directories have to use snake_case (e.g., user_profile.dart)
  • Imports have to use full package paths (e.g., package:app_name/path/file.dart)
  • If Conditions have to split long/complex conditions into variables for readability

Example of a long if condition violation:

if (userDataProvider.isLoggedIn &&
    (userDataProvider.userProfileModel.classifications?.staff ?? false)) {
  // action
}
// GOOD: split condition into variables for readability
var isLoggedIn = userDataProvider.isLoggedIn;
var isStaff = userDataProvider.userProfileModel.classifications?.staff ?? false;
if (isLoggedIn && isStaff) {
  // action
}

To see more details and fix these violations:

  1. Run ./scripts/auto_check_all.sh locally.
  2. Apply the suggested corrections.
  3. Re-run the script to verify fixes.
  4. Commit your changes.

This comment will continue to appear until all violations are resolved.

angelawu236
angelawu236 previously approved these changes Mar 12, 2026
@hamedhemmati hamedhemmati dismissed angelawu236’s stale review March 12, 2026 23:00

The merge-base changed after approval.

angelawu236
angelawu236 previously approved these changes Mar 12, 2026
@hamedhemmati hamedhemmati dismissed angelawu236’s stale review March 12, 2026 23:14

The merge-base changed after approval.

@c3bryant c3bryant changed the title [MA-547] Testing card view analytics [MA-547] Implement card view analytics Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants