Skip to content

[MA-581] Android notification permission fix#2291

Merged
hamedhemmati merged 3 commits intoexperimentalfrom
haemd-android-notification
Mar 12, 2026
Merged

[MA-581] Android notification permission fix#2291
hamedhemmati merged 3 commits intoexperimentalfrom
haemd-android-notification

Conversation

@hamedhemmati
Copy link
Collaborator

Summary

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Code Style Violations Found

  • Static Constants (UPPER_SNAKE_CASE): 1 violations

Total Violations: 1
Total Categories Failed: 1/6

Here are the formatting rules to follow:

  • Static Constants have to use UPPER_SNAKE_CASE (e.g., MAX_RETRY_COUNT)
  • Classes have to use UpperCamelCase (e.g., UserProfile)
  • Variables/Functions have to use lowerCamelCase (e.g., userName)
  • Files/Directories have to use snake_case (e.g., user_profile.dart)
  • Imports have to use full package paths (e.g., package:app_name/path/file.dart)
  • If Conditions have to split long/complex conditions into variables for readability

Example of a long if condition violation:

if (userDataProvider.isLoggedIn &&
    (userDataProvider.userProfileModel.classifications?.staff ?? false)) {
  // action
}
// GOOD: split condition into variables for readability
var isLoggedIn = userDataProvider.isLoggedIn;
var isStaff = userDataProvider.userProfileModel.classifications?.staff ?? false;
if (isLoggedIn && isStaff) {
  // action
}

To see more details and fix these violations:

  1. Run ./scripts/auto_check_all.sh locally.
  2. Apply the suggested corrections.
  3. Re-run the script to verify fixes.
  4. Commit your changes.

This comment will continue to appear until all violations are resolved.

@hamedhemmati hamedhemmati merged commit 5e36b83 into experimental Mar 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants