Skip to content

[MA-547] Implement card view analytics and card reload bug fix#2294

Open
hamedhemmati wants to merge 2 commits intoexperimentalfrom
Hamed-Alessio-changes
Open

[MA-547] Implement card view analytics and card reload bug fix#2294
hamedhemmati wants to merge 2 commits intoexperimentalfrom
Hamed-Alessio-changes

Conversation

@hamedhemmati
Copy link
Collaborator

Summary

Changelog

[CATEGORY] [TYPE] - Message

Test Plan

@hamedhemmati hamedhemmati requested a review from c3bryant March 16, 2026 20:44
@github-actions
Copy link

Code Style Violations Found

  • Very Long If Statement Conditions: 1 violations

Total Violations: 1
Total Categories Failed: 1/6

Here are the formatting rules to follow:

  • Static Constants have to use UPPER_SNAKE_CASE (e.g., MAX_RETRY_COUNT)
  • Classes have to use UpperCamelCase (e.g., UserProfile)
  • Variables/Functions have to use lowerCamelCase (e.g., userName)
  • Files/Directories have to use snake_case (e.g., user_profile.dart)
  • Imports have to use full package paths (e.g., package:app_name/path/file.dart)
  • If Conditions have to split long/complex conditions into variables for readability

Example of a long if condition violation:

if (userDataProvider.isLoggedIn &&
    (userDataProvider.userProfileModel.classifications?.staff ?? false)) {
  // action
}
// GOOD: split condition into variables for readability
var isLoggedIn = userDataProvider.isLoggedIn;
var isStaff = userDataProvider.userProfileModel.classifications?.staff ?? false;
if (isLoggedIn && isStaff) {
  // action
}

To see more details and fix these violations:

  1. Run ./scripts/auto_check_all.sh locally.
  2. Apply the suggested corrections.
  3. Re-run the script to verify fixes.
  4. Commit your changes.

This comment will continue to appear until all violations are resolved.

@github-actions
Copy link

Code Style Violations Found

  • Very Long If Statement Conditions: 1 violations

Total Violations: 1
Total Categories Failed: 1/6

Here are the formatting rules to follow:

  • Static Constants have to use UPPER_SNAKE_CASE (e.g., MAX_RETRY_COUNT)
  • Classes have to use UpperCamelCase (e.g., UserProfile)
  • Variables/Functions have to use lowerCamelCase (e.g., userName)
  • Files/Directories have to use snake_case (e.g., user_profile.dart)
  • Imports have to use full package paths (e.g., package:app_name/path/file.dart)
  • If Conditions have to split long/complex conditions into variables for readability

Example of a long if condition violation:

if (userDataProvider.isLoggedIn &&
    (userDataProvider.userProfileModel.classifications?.staff ?? false)) {
  // action
}
// GOOD: split condition into variables for readability
var isLoggedIn = userDataProvider.isLoggedIn;
var isStaff = userDataProvider.userProfileModel.classifications?.staff ?? false;
if (isLoggedIn && isStaff) {
  // action
}

To see more details and fix these violations:

  1. Run ./scripts/auto_check_all.sh locally.
  2. Apply the suggested corrections.
  3. Re-run the script to verify fixes.
  4. Commit your changes.

This comment will continue to appear until all violations are resolved.

),
title: Text(
'Feedback & Support',
'Get Mobile App Support',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify later if this change should be included.

minRadius: 20,
backgroundColor: circleColor,
foregroundColor: textColor,
backgroundColor: HexColor(shuttle.routeColor),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify later if this change should be included.


class ParkingDefaults {
static const DEFAULT_LOTS = ["Athena", "Gilman", "Hopkins", "Theatre District", "South", "First Ave"];
static const DEFAULT_LOTS = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify later if this change should be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants