-
Notifications
You must be signed in to change notification settings - Fork 278
feat(ui5-table-cell): merged property added #13297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,4 +1,5 @@ | ||||||
| import customElement from "@ui5/webcomponents-base/dist/decorators/customElement.js"; | ||||||
| import property from "@ui5/webcomponents-base/dist/decorators/property.js"; | ||||||
| import query from "@ui5/webcomponents-base/dist/decorators/query.js"; | ||||||
| import TableCellTemplate from "./TableCellTemplate.js"; | ||||||
| import TableCellStyles from "./generated/themes/TableCell.css.js"; | ||||||
|
|
@@ -30,6 +31,20 @@ import { LABEL_COLON } from "./generated/i18n/i18n-defaults.js"; | |||||
| template: TableCellTemplate, | ||||||
| }) | ||||||
| class TableCell extends TableCellBase { | ||||||
| /** | ||||||
| * Defines whether the cell is visually merged with the cell directly above it. | ||||||
| * | ||||||
| * This is useful when consecutive cells in a column have the same value and should visually appear as a single merged cell. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| * Although the cell is visually merged with the previous one, its content must still be provided for accessibility purposes. | ||||||
| * **Note:** This feature is disabled when cells are rendered as popin, and should remain `false` for interactive cell content. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should or must?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. with the new design we show the merged content on focus and hover so I think "should" is fine.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| * | ||||||
| * @default false | ||||||
| * @since 2.21.0 | ||||||
| * @public | ||||||
| */ | ||||||
| @property({ type: Boolean }) | ||||||
| merged = false; | ||||||
|
|
||||||
| @query("#popin-header") | ||||||
| _popinHeader?: HTMLElement; | ||||||
|
|
||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.