Skip to content

Feature/DIMS refactor GenerateViolinPlots#82

Open
ALuesink wants to merge 34 commits intodevelopfrom
feature/DIMS_refactor_GenerateViolinPlots
Open

Feature/DIMS refactor GenerateViolinPlots#82
ALuesink wants to merge 34 commits intodevelopfrom
feature/DIMS_refactor_GenerateViolinPlots

Conversation

@ALuesink
Copy link
Contributor

@ALuesink ALuesink commented Aug 15, 2025

The refactor of GenerateViolinPlots:

  • code to functions
  • added unit tests

@ALuesink ALuesink marked this pull request as ready for review August 21, 2025 12:52
@ALuesink ALuesink changed the base branch from main to develop November 3, 2025 08:24
@rernst rernst self-requested a review November 18, 2025 14:54
Copy link
Member

@rernst rernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all lots of work done, good job! I feel like there is room for improvement, some general thoughts:

  1. Many parameters have names like metab_interest_sorted. In the context of a function, it’s not relevant whether the input is “of interest” or “sorted.” Use neutral, descriptive names that reflect the data type or role.

  2. Several functions are named after their use case rather than their functionality. name functions based on what they do, not where they are used.

  3. When breaking function calls across lines, maintain a consistent style. Preferred format:

Rfunction1(
   function_2(param_a),  
   param_b,  
   param_c,
)
  1. There is no error catching for missing files or invalid paths. Currently, the code will crash, making debugging difficult.

  2. There seems to be a lot of ad-hoc data transformations. It feels like the DIMS application is missing a standardized data format for saving and reusing data between steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants