remove scripting api's marked as unused#9
Open
adamkorynta wants to merge 5 commits into
Open
Conversation
to ensure removed api's still allow the application to compile, the gradle build and github actions were added for the CI/CD check
krowvin
reviewed
Jul 6, 2026
krowvin
left a comment
krowvin
left a comment
Contributor
There was a problem hiding this comment.
Unsure of the args, up to you if that needs a fix!
Comment on lines
-89
to
+93
| ManagerId managerId = factory.getManagerId(opt); | ||
| RegiDomain regiDomain = factory.createDomain(opt, managerId); | ||
| ManagerId managerId = factory.getManagerId(); | ||
| RegiDomain regiDomain = factory.createDomain(); |
Contributor
There was a problem hiding this comment.
But then here they are not used?
Wasn't sure if the intent was to allow them for backwards compatibility but just use the env. Might be confusing though going forward?
I might throw a warning if that was the intent.
| private static void runHeadless(CmdLineParser parser, String[] args, CLIOptions opt) | ||
| throws DbConnectionException, InvalidDbConnectionException, CmdLineException, DbPluginNotFoundException, | ||
| IOException { | ||
| parser.parseArgument(args); |
Contributor
There was a problem hiding this comment.
Args appear to be exposed here still, possibly for backwards compat?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to ensure removed api's still allow the application to compile, the gradle build and github actions were added for the CI/CD check