Skip to content

Add linting (code formatting) action to the PCR-GLOBWB_model master branch#38

Open
BramDr wants to merge 1 commit into
UU-Hydro:masterfrom
BramDr:feature/linting_action
Open

Add linting (code formatting) action to the PCR-GLOBWB_model master branch#38
BramDr wants to merge 1 commit into
UU-Hydro:masterfrom
BramDr:feature/linting_action

Conversation

@BramDr
Copy link
Copy Markdown
Contributor

@BramDr BramDr commented Mar 1, 2024

GitHub Actions are automated processes that fire during any GitHub action, such as push or pull request. I have added a GitHub action that automatically lints the code in the repository using isort for the python imports and black for the code, for any push to the master branch. It does so by automatically generating another commit with the fixes to the code.

This GitHub Action integration will help maintain a clear an structured code-base and fixes #30, fixes #29 and fixes #28 automatically (also in the future).

Possible downsides:

  1. Strict black formatting applied
  2. New commit after every push (so maybe make development branch, in line with issue Make development branch #37)

@BramDr BramDr added the enhancement Enhancement request label Mar 1, 2024
@BramDr BramDr linked an issue Mar 1, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reorder imports according to PEP8 Get rid of unused module imports Get rid of useless white space in the code

2 participants