This repository was archived by the owner on Sep 13, 2023. It is now read-only.
Sitansh Mehta Autonomy Bootcamp#168
Open
sitanshmehta wants to merge 2 commits intoUWARG:masterfrom
Open
Conversation
added 2 commits
May 24, 2023 20:54
mgupta27
reviewed
May 30, 2023
| super(Network, self).__init__() | ||
| self.conv1 = nn.Conv2d( | ||
| in_channels=3, out_channels=32, kernel_size=(3, 3)) | ||
| self.conv2 = nn.Conv2d( |
There was a problem hiding this comment.
Nit: I'd suggest have a max pooling layer in the middle of the convultion layers
mgupta27
approved these changes
May 30, 2023
mgupta27
left a comment
mgupta27
left a comment
There was a problem hiding this comment.
Looks good overall. I like how your code is modularized. Welcome to the Autonomy team! Take a look at this document for next steps. Hope to see you next Monday!
https://uwarg-docs.atlassian.net/wiki/spaces/CV/pages/2060353537/Autonomy+Onboarding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.