Conversation
lllumineux
commented
Aug 28, 2019
- add node_modules & local_config.py to .gitignore
- replace example_config.py to the main folder and delete the folder named "infolesson"
|
rip to travis ci |
| node_modules/ | ||
|
|
||
| # Config files | ||
| local_config.py |
There was a problem hiding this comment.
This file already exists in gitignore, look at the last line of the file
|
|
||
| # IDE files | ||
| .idea/ | ||
| node_modules/ |
There was a problem hiding this comment.
I don't think node_modules is IDE files, pls add some cool comment
|
Also pls leave |
|
Listen up, why the fuck I had got local_config.py ready to be committed if it already were in .gitignore? And bout' "infolesson" folder: this is stupid to have such folder, it'd better to have "src" folder for development's files & "dist" folder for production's one. But I'm not sure yet if we should commit "dist" folder, we'll discuss it later. And furthermore, example_config.py directly belongs to project, there will be package.json, package-lock.json and 3 more different webpack.config files, we will have them stored in the main folder, so other config files should be stored in there too.
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: BardRandall <notifications@github.com>
Sent: Wednesday, August 28, 2019 10:35:06 PM
To: UlstuLyceum/InfoLesson <InfoLesson@noreply.github.com>
Cc: Ramil Suleymanov <lllumineux@outlook.com>; Assign <assign@noreply.github.com>
Subject: Re: [UlstuLyceum/InfoLesson] Update .gitignore (#3)
Also pls leave example_config.py file in folder infolesson, because all executable files will be there. Outside you can see just some files, that not directly belongs to project.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<#3?email_source=notifications&email_token=AKY3HKOPI6NB3DBRKCZQ36DQG3ANVA5CNFSM4IRMYYM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MCCIY#issuecomment-525869347>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AKY3HKMQMM2B346ZUSPMO43QG3ANVANCNFSM4IRMYYMQ>.
|
|
Pls look at structure of this project: https://github.com/summer-school-2019/money-bot. |
|
This is a bot project, and we are creating a web-site! It's incorrect to compare them! Let's have a discussion about project structure in discord. |