Open
Conversation
CURA-11658
This update refines the cleanup process across different parts of the application. Node reset functionality has been introduced which thoroughly cleans up the memory. Clear functions within SettingOverrideDecorator, SceneNodeDecorator, ConvexHullDecorator and others are improved to completely cleanse after usage. This approach ensures a more efficient use and management of memory resources. CURA-11658
only the set of operations within the specified range are deleted. This fine-tuned approach minimizes needless memory cleanups and enhances overall memory management. CURA-11658
CURA-11658
wawanbreton
reviewed
Apr 18, 2024
Contributor
wawanbreton
left a comment
wawanbreton
left a comment
There was a problem hiding this comment.
Same remark as for the other PR, I'm afraid of crashes, and I think methods naming is inconsistent.
The "clear" method has been renamed to "clearDecoratorData" to improve clarity on its function in several classes. This change affects the SettingOverrideDecorator, SceneNodeDecorator, ConvexHullDecorator, and SceneNode classes. CURA-11658
wawanbreton
approved these changes
Apr 26, 2024
Contributor
wawanbreton
left a comment
wawanbreton
left a comment
There was a problem hiding this comment.
Same remark as for Ultimaker/Cura#18883, still some reserve about this but I let you move on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CURA-11658