CURA-12099 export and import to bambu 3mf #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURA-12099
rburema
approved these changes
Apr 24, 2025
Member
rburema
left a comment
rburema
left a comment
There was a problem hiding this comment.
👍🏻
(I'll inform the other PR that we'd like to do it this way.)
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for exporting and importing 3MF 3D models by introducing a new method to parse external component files. The changes include:
- Adding getComponentPath() and parseComponentData() methods in SceneNode.
- Updating fillByXMLNode() to process external component nodes.
- Bumping the dependency version in conandata.yml to 5.11.0-alpha.0.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/SceneNode.cpp | New methods for component data handling and XML parsing |
| include/Savitar/SceneNode.h | Header declarations for the new component handling methods |
| conandata.yml | Version bump supporting the updated functionality |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method to parse 3D models defined in separate component files
CURA-12099