Skip to content

Revert FrankenPHP integration#748

Merged
superdav42 merged 2 commits intomainfrom
revert/frankenphp-integration
Apr 4, 2026
Merged

Revert FrankenPHP integration#748
superdav42 merged 2 commits intomainfrom
revert/frankenphp-integration

Conversation

@superdav42
Copy link
Copy Markdown
Collaborator

@superdav42 superdav42 commented Apr 4, 2026

Summary

  • Reverts the FrankenPHP/Caddy integration that was added but is not needed — on-demand TLS is handled at the server level (Trellis/Caddyfile), not the plugin level
  • Removes inc/integrations/providers/frankenphp/ (2 files, ~455 lines)
  • Restores the previously removed Plesk, BunnyNet, LaravelForge, and Amazon SES integrations to the registry

Reverts commits:

  • 078f7f08 refactor: simplify FrankenPHP integration — on-demand TLS handles everything
  • f775968d feat: add FrankenPHP/Caddy integration for automatic Let's Encrypt SSL

Summary by CodeRabbit

  • New Features

    • Added support for Plesk, BunnyNet, Laravel Forge, and Amazon SES integrations with corresponding domain mapping capabilities.
  • Deprecations

    • Removed FrankenPHP integration support.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 4, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d725e0cd-afd5-40f2-80be-59eb9291897b

📥 Commits

Reviewing files that changed from the base of the PR and between 0a5ca22 and 2218731.

📒 Files selected for processing (3)
  • inc/integrations/class-integration-registry.php
  • inc/integrations/providers/frankenphp/class-frankenphp-domain-mapping.php
  • inc/integrations/providers/frankenphp/class-frankenphp-integration.php
💤 Files with no reviewable changes (2)
  • inc/integrations/providers/frankenphp/class-frankenphp-integration.php
  • inc/integrations/providers/frankenphp/class-frankenphp-domain-mapping.php

📝 Walkthrough

Walkthrough

The changes remove the FrankenPHP provider integration and its domain mapping capability module, and register four new provider integrations (Plesk, BunnyNet, LaravelForge, and Amazon_SES) with their corresponding capability modules in the integration registry.

Changes

Cohort / File(s) Summary
Integration Registry
inc/integrations/class-integration-registry.php
Updates registry to deregister FrankenPHP and register three new provider integrations (Plesk, BunnyNet, LaravelForge) and Amazon_SES. Adds corresponding capability modules: plesk with Plesk_Domain_Mapping, bunnynet with BunnyNet_Domain_Mapping, laravel-forge with LaravelForge_Domain_Mapping, and amazon-ses with Amazon_SES_Transactional_Email.
FrankenPHP Provider Removal
inc/integrations/providers/frankenphp/class-frankenphp-domain-mapping.php, inc/integrations/providers/frankenphp/class-frankenphp-integration.php
Removes FrankenPHP provider implementation including: domain mapping capability with Caddy TLS integration, REST endpoint for domain validation with IP-based allowlist, domain state handlers, and FrankenPHP environment detection and admin API communication logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Poem

🐰 The FrankenPHP hops away into the code,
While Plesk, BunnyNet, and Laravel Forge load,
Amazon sends emails with grace and delight,
The registry dances with providers so bright! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Revert FrankenPHP integration' directly describes the main change—removing the FrankenPHP integration and restoring other providers—which is confirmed by both the file summary and PR objectives.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert/frankenphp-integration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@superdav42 superdav42 merged commit 2353ff7 into main Apr 4, 2026
11 checks passed
@superdav42
Copy link
Copy Markdown
Collaborator Author

Completed via PR #748, merged to main.

Merged by deterministic merge pass (pulse-wrapper.sh). No worker summary was available — the worker either crashed before writing one or this PR predates the merge summary convention.

aidevops.sh v3.6.11 spent 6m on this as a headless bash routine.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Performance Test Results

Performance test results for 74759c6 are in 🛎️!

Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown.

URL: /

Run DB Queries Memory Before Template Template WP Total LCP TTFB LCP - TTFB
0 41 37.80 MB 885.00 ms 157.00 ms (-4.50 ms / -3% ) 1117.00 ms (+24.00 ms / +2% ) 2072.00 ms 1974.25 ms 95.15 ms
1 56 49.02 MB 935.00 ms 148.00 ms 1089.00 ms 2066.00 ms 1981.50 ms 83.00 ms (-2.15 ms / -3% )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant