[SG2] Asset structure refactor#7745
Open
Nightmask3 wants to merge 8 commits into
Open
Conversation
# Conflicts: # com.unity.sg2/Editor/GraphUI/Importers/ShaderGraphAssetImporterEditor.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR implements work described here: https://jira.unity3d.com/browse/GSG-1474
Miro board with notes of ongoing work: https://miro.com/app/board/uXjVPHn19jQ=/
This PR refactors the relationship between the
ShaderGraphModeland theGraphHandler(the CLDS model), to look like this:The
ShaderGraphModelno longer owns theGraphHandler, theShaderGraphAssetis now responsible for owning and instantiating theGraphHandler.Unity_dPf2XLcCoj.mp4
Outstanding issues with this branch:
ShaderGraphAssetUtils.HandleImportAssetGraphTesting status:
Manual developer testing to validate what works and what doesn't. Automated tests were not run yet at time of branch creation.
Comments to reviewers
Notes for the reviewers you have assigned.