Skip to content

Fix for right click menu in preview on Mac.#7814

Open
iTris666 wants to merge 1 commit into
sg2/mainfrom
sg2/fix/preview-menu-mac
Open

Fix for right click menu in preview on Mac.#7814
iTris666 wants to merge 1 commit into
sg2/mainfrom
sg2/fix/preview-menu-mac

Conversation

@iTris666

@iTris666 iTris666 commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

Purpose of this PR

Fix a bug on Mac where if you display the right click menu on the preview, the preview then keeps scrolling when you move the mouse over it without a button pressed.

Also made sure the preview was resilient when given Nan size ( which currently happens with the overlays ).


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions

Copy link
Copy Markdown

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page).
See the PR template for more information.
Thank you!

@iTris666 iTris666 requested a review from Nightmask3 February 10, 2023 14:39
@iTris666 iTris666 force-pushed the sg2/fix/preview-menu-mac branch from 255e4e6 to e7c4708 Compare February 10, 2023 16:02
Base automatically changed from sg2/upcoming-staging to sg2/main February 13, 2023 18:57

@Nightmask3 Nightmask3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iTris666 iTris666 requested a review from smooffins February 20, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants