[SG2]Imposter nodes and documents#7865
Open
tracychen1234 wants to merge 21 commits into
Open
Conversation
|
It appears that you made a non-draft PR! |
This reverts commit dba3cd2.
tracychen1234
commented
Apr 17, 2023
Contributor
Author
There was a problem hiding this comment.
Is there a better place to put this hlsl file?
MattSutherlin
approved these changes
Apr 17, 2023
bencloward
suggested changes
Apr 17, 2023
bencloward
left a comment
bencloward
left a comment
Contributor
There was a problem hiding this comment.
I need to do a bit more work on this to test our the actual nodes themselves but I won't be able to do that until tomorrow, so I'm just going to submit this bit now and then look at it some more tomorrow when I can switch to your branch and try it.
|
|
||
| ## Description | ||
|
|
||
| The Imposter UV Node calculates the billboard positon and the virtual UVs for sampling. |
Contributor
There was a problem hiding this comment.
How about we say: "The Imposter UV Node calculates the billboard position (fix the typo in this word) and the UV coordinates needed by the Imposter Sample node." We need to indicate that data output here is intended specifically for the Imposter Sample node.
bencloward
suggested changes
Apr 18, 2023
| @"ImposterSample(HeightMapChannel, ViewDirectionTS, Parallax, Frames, Texture.tex, Texture.texelSize, Clip, Grid, UV0, UV1, UV2, Sampler.samplerstate, RGBA);", | ||
| new ParameterDescriptor[] | ||
| { | ||
| new ParameterDescriptor("Texture", TYPE.Texture2D, Usage.In), |
Contributor
There was a problem hiding this comment.
Should this be an array texture?
Contributor
Author
There was a problem hiding this comment.
in the current set up it needs to be a single texture split into frames.
This reverts commit 7aadd3d.
bencloward
suggested changes
Apr 25, 2023
bencloward
left a comment
bencloward
left a comment
Contributor
There was a problem hiding this comment.
Making great progress on this!
bencloward
reviewed
Apr 25, 2023
bencloward
reviewed
Apr 27, 2023
bencloward
suggested changes
Apr 27, 2023
bencloward
approved these changes
Apr 27, 2023
xiaoxicici
approved these changes
Apr 28, 2023
xiaoxicici
left a comment
xiaoxicici
left a comment
There was a problem hiding this comment.
I reviewed with Tracy live. Main discoveries are:
- Align heightmap port naming with the existing Parallax node.
- Texture size allows user input though would only work with square of 2s, something we might want to handle more elegantly, i.g. change the input field to dropdown selections. And user may have difference resolution on base color vs mask textures for example.
This is super valuable work and useful for users, so great job Tracy! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Add imposter nodes and related documents to the node library.
Testing status
Connect the outputs of the nodes to the context node in an sg2 graph, and no error is shown.
Comments to reviewers