[DO NOT MERGE! Work is parked currently] [MTT-8685] Feat: UIToolkit for BossRoom: PostGame UI#900
Open
Elfi0Kuhndorf wants to merge 31 commits intodevelopfrom
Open
[DO NOT MERGE! Work is parked currently] [MTT-8685] Feat: UIToolkit for BossRoom: PostGame UI#900Elfi0Kuhndorf wants to merge 31 commits intodevelopfrom
Elfi0Kuhndorf wants to merge 31 commits intodevelopfrom
Conversation
Elfi0Kuhndorf
changed the title
…uitPanel ConnectionManager does not get injected successfully
…ing hover state for menuButtons
… with screen size
Elfi0Kuhndorf
changed the title
Elfi0Kuhndorf
changed the title
…onent assignment in script
not fully working yet
…) and trying to get injection of PostGameUI to work
… elements; fixing naming and button execution in scripts
add changes to uss
…eed uxml into post game uxml
…cenes, removing scroller from message feed, adding delay for fadoutAnim and cleaning up code
|
|
kalmanbalint
requested changes
Feb 28, 2025
kalmanbalint
left a comment
kalmanbalint
left a comment
There was a problem hiding this comment.
All in all great work!
there are a few nit pick I have, feel free to disregard those
the only real issue I see is the bug with the ListView control and the animations related to the message items, which I am to blame for 😅
…and adjusting UIMessageFeed.cs accordingly
Elfi0Kuhndorf
changed the title
Elfi0Kuhndorf
added
4-On Hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjusting scripts and creating assets to transform the UI elements within the Post Game scene to UIToolkit. This includes the SettingsPanelCanvas and the PostGameUICanvas
Issue Number(s)
https://jira.unity3d.com/browse/MTT-8685
Contribution checklist